Skip to content

[Backport staging-25.05] nodejs_22: re-add patch to fix sandboxed builds using gyp on Darwin#417453

Merged
vcunat merged 1 commit intostaging-25.05from
backport-416077-to-staging-25.05
Jun 18, 2025
Merged

[Backport staging-25.05] nodejs_22: re-add patch to fix sandboxed builds using gyp on Darwin#417453
vcunat merged 1 commit intostaging-25.05from
backport-416077-to-staging-25.05

Conversation

@nixpkgs-ci
Copy link
Contributor

@nixpkgs-ci nixpkgs-ci bot commented Jun 17, 2025 •
edited by vcunat
Loading

Bot-based backport to staging-25.05, triggered by a label in #416077.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-committer, if you find that it is not acceptable, leave a comment.

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Jun 17, 2025
Merged
13 tasks
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jun 17, 2025
@nix-owners nix-owners bot requested a review from aduh95 June 17, 2025 07:29
@github-actions github-actions bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 4.workflow: backport This targets a stable branch labels Jun 17, 2025
@github-actions github-actions bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jun 17, 2025
@FliegendeWurst
Copy link
Member

FliegendeWurst commented Jun 17, 2025

I got some test failures on aarch64-darwin.

not ok 3239 parallel/test-watch-file-shared-dependency
  ---
  duration_ms: 323.70700
  severity: fail
  exitcode: 1
  stack: |-
    TAP version 13
    # Subtest: watch file with shared dependency
        # Subtest: should not remove shared dependencies when unfiltering an owner
        not ok 1 - should not remove shared dependencies when unfiltering an owner
          ---
          duration_ms: 1.698833
          location: '/private/tmp/nix-build-nodejs-22.14.0.drv-0/node-v22.14.0/test/parallel/test-watch-file-shared-dependency.mjs:33:3'
          failureType: 'uncaughtException'
          error: 'EMFILE: too many open files, watch'
          code: 'EMFILE'
          stack: |-
            FSWatcher._handle.onchange (node:internal/fs/watchers:207:21)
          ...
        1..1
    not ok 1 - watch file with shared dependency
...
Failed tests:
out/Release/node --expose-internals /private/tmp/nix-build-nodejs-22.14.0.drv-0/node-v22.14.0/test/parallel/test-runner-complex-dependencies.mjs
out/Release/node --expose-internals /private/tmp/nix-build-nodejs-22.14.0.drv-0/node-v22.14.0/test/parallel/test-watch-file-shared-dependency.mjs

Will rerun with lower concurrency... but it shouldn't be related to this change.

@vcunat vcunat merged commit 39b50d5 into staging-25.05 Jun 18, 2025
16 of 18 checks passed
@wolfgangwalther wolfgangwalther deleted the backport-416077-to-staging-25.05 branch June 20, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95 aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

4.workflow: backport This targets a stable branch 6.topic: darwin Running or building packages on Darwin 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@FliegendeWurst @aduh95 @vcunat @fugidev